This repository was archived by the owner on Dec 3, 2024. It is now read-only.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is work in progress and contains the refactoring for V2 of this package.
With the update I aim for an even easier integration and less friction.
V1 used an event approach to deliver the EditorJS content to you. This wasn't ideal and unnecessary.
Also V1 used a Livewire component to package everything up. By now I think it's better to use a "simple" Blade component, which you can use in YOUR Livewire component.
This way you get way more control over the data and less stuff is hidden from you.
At first this may sound like a lot more work is put on your shoulders, but let me show you how it will look like:
contentgets entangled to your Livewire components content property and passed to editorjs using x-model.As you can see, we can even use "defer" here now, so that only on save the editors state is updated in your Livewire component.
This is still work in progress, but you can see where it's heading!