fix: update timeArray validation to handle non-numeric strings (#49)

* fix: update timeArray validation to handle non-numeric strings * chore: rename function argument: seconds to timeString
matzar · Sep 5, 2023 · 627ead7 · 627ead7
1 parent 00e5cae
commit 627ead7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -1,9 +1,9 @@
 "use strict";
 
-module.exports = function (seconds) {
-  let timeArray = seconds.split(":");
+module.exports = function (timeString) {
+  let timeArray = timeString.split(":");
 
-  if (timeArray.some(isNaN))
+  if (timeArray.some((val) => Number.isNaN(Number(val))))
     throw new TypeError(
       'time-to-seconds: wrong argument type - something else than a number string in format "number", "number:number" or "number:number:number" was passed. See documentation for more information on argument formatting: https://www.npmjs.com/package/time-to-seconds.'
     );

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@matzar/time-to-seconds",
-  "version": "2.1.2",
+  "version": "2.1.3",
   "description": "Non-strict format, time to seconds converter ",
   "main": "index.js",
   "scripts": {