chore: fix low hanging lints #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy is rightfully erroring about `derived_hash_with_manual_eq` as given that the `k1 == k2 ⇒ hash(k1) == hash(k2)` invariant isn't being respected.
Violates `mut_from_ref` clippy error.
Ran: ```sh fd --hidden --type file .rs | xargs \ sed --regexp-extended -i -e 's/(#!|\s*#)\[allow\(unused\)\]//g' ```
|
Just checking - the intent is here is to keep the unused warnings? Is that happening as a part of the next PR? |
|
The intent was to remove most of the unused code, only to then realize that it was a lot (600+ clippy warnings, excluding commented out code). I can remove that commit for now if it makes more sense. |
|
Got it - I didn't realize I was that far behind on clippy warnings 😅 - so this does need to get addressed eventually. The next MR starts to address the unused code right? So in theory the warnings living on master wouldn't live for too long? Also, could we leave the unused in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first (of probably many) that aims to bring steel closer to being able to run clippy as part of the CI.
Each crate will probably need its own PR for their remaining lint warnings and suggestions.
#[allow(unused)]annotationscargo fix