Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle submodules not updating #200

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

devnoname120
Copy link
Contributor

@devnoname120 devnoname120 commented Nov 18, 2024

Overview

Antidote doesn't update or clone the new submodules when running antidote update. It only does when calling the first antidote install.

How to reproduce

antidote install -b v5.8.3 olets/zsh-abbr

pushd "$(antidote path olets/zsh-abbr)"
git config remote.origin.fetch "+refs/heads/*:refs/remotes/origin/*"
git fetch origin main
git checkout -b main 
git branch --set-upstream-to=origin/main
popd

echo "olets/zsh-abbr branch:v6.0.0" > ~/.zsh_plugins.txt
antidote update

Then:

❯ antidote load ~/.zsh_plugins.txt
abbr: Finishing installing dependencies
abbr: There was a problem finishing installing dependencies

Same reproduction instructions as above but this time with my fix and now the output looks good:

❯ antidote load ~/.zsh_plugins.txt

@mattmc3
Copy link
Owner

mattmc3 commented Nov 19, 2024

Thank you for this. I'll try to look more closely later this week and see if there's some more meaningful tests that need added to put this feature through it's paces. I suspect the only change I'd ask for is the addition of the --quiet flag, but I want to try some edge cases first.

@mattmc3 mattmc3 merged commit 64b7864 into mattmc3:main Nov 20, 2024
2 checks passed
@devnoname120 devnoname120 deleted the fix-bundle-submodule-update branch November 21, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants