Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Candiff to compare logs #8

Merged
merged 14 commits into from
Aug 26, 2020
Merged

Use Candiff to compare logs #8

merged 14 commits into from
Aug 26, 2020

Conversation

matthewhammer
Copy link
Owner

@matthewhammer matthewhammer commented Aug 24, 2020

Addresses #7

  • Save and emit the call request-response log to compare across distinct CI runs
  • Download candiff release binary in CI script (avoid rebuilding from source, which is slow)
  • Compare logs across runs

@matthewhammer matthewhammer marked this pull request as ready for review August 24, 2020 12:10
@matthewhammer
Copy link
Owner Author

This PR is passing CI, but candiff is barfing on what seems to be a minor mismatch between didc and candiff syntax expectations.

test.sh Outdated Show resolved Hide resolved
@matthewhammer
Copy link
Owner Author

Merging this now.
Loose end for another PR:

  • As discussed with @chenyan-dfinity, there is a mismatch between IDLArgs and IDLValue between the two tools. Seems like an easy fix with an appropriate flag in the candiff tool, which currently expects the latter but should understand the former.

@matthewhammer matthewhammer merged commit 68a7c00 into master Aug 26, 2020
@matthewhammer matthewhammer deleted the candiff-release branch August 26, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants