Skip to content

Conversation

focux
Copy link

@focux focux commented May 23, 2024

Summary

If a project uses dynamic frameworks on iOS, projects that include this library will not compile. This PR fixes that issue.

Ticket Link

Fixes #22

@enahum
Copy link
Contributor

enahum commented May 23, 2024

Thanks for the PR

@enahum enahum requested a review from larkox May 23, 2024 23:26
@enahum enahum added the 2: Dev Review Requires review by a core committer label May 23, 2024
@focux
Copy link
Author

focux commented May 27, 2024

Awesome, let me know if there's something else I can do to get this merged 🙏

@TowhidKashem
Copy link

@focux I use use_frameworks (for react native firebase support) and I was able to install and use this lib without any other changes. Is the issue you noticed something that occurs right off the bat or is it hidden behind some flow?

@focux
Copy link
Author

focux commented Aug 7, 2024

You will find more information in #22, but it's not hidden behind any flow, it happens every time I try to build my app for dev or release.

@TowhidKashem
Copy link

You will find more information in #22, but it's no hidden behind any flow, it happens every time I try to build my app for dev or release.

Odd, I'm able to run it just fine in an expo managed workflow using dev client. I haven't tried on prod or simulator yet but dev build works. Anyway might be something else interacting with it in my system to have the different effect. Carry on then..

@larkox
Copy link
Contributor

larkox commented Aug 8, 2024

@focux Sorry for the long delay with this. Somehow fell through the cracks.

We have updated several things in the library, and there seems to be a merge conflict. Can you verify if the change is still needed and update the PR?

@enahum
Copy link
Contributor

enahum commented Mar 9, 2025

bump on this one

@mattermost-build
Copy link

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer Lifecycle/1:stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expo error
5 participants