-
Notifications
You must be signed in to change notification settings - Fork 31
Fix use_frameworks! #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR |
Awesome, let me know if there's something else I can do to get this merged 🙏 |
@focux I use |
You will find more information in #22, but it's not hidden behind any flow, it happens every time I try to build my app for dev or release. |
Odd, I'm able to run it just fine in an expo managed workflow using dev client. I haven't tried on prod or simulator yet but dev build works. Anyway might be something else interacting with it in my system to have the different effect. Carry on then.. |
@focux Sorry for the long delay with this. Somehow fell through the cracks. We have updated several things in the library, and there seems to be a merge conflict. Can you verify if the change is still needed and update the PR? |
bump on this one |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
If a project uses dynamic frameworks on iOS, projects that include this library will not compile. This PR fixes that issue.
Ticket Link
Fixes #22