bug fixes #26
Open
bug fixes #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
requested changes
Aug 26, 2023
android/src/main/java/com/mattermost/pasteinput/PasteInputEditText.kt
Outdated
Show resolved
Hide resolved
…Text.kt Co-authored-by: Elias Nahum <[email protected]>
yes, but it seems this change broke the samsung keyboard again. I don't think it can support all types, at least not the way it was specified. my suggestion is to add this as a parameter to the library where you can specify the mime types to accept. that's beyond my scope of expertise here. |
|
actually, it seems to still work with the samsung keyboard... |
|
These changes unbroke my iOS installation (not using expo, just standard react native version 0.71) and my samsung android testing device works. (clipboard works, but hitting the paste tooltip button doesn't work) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bugs for #25 #24 #22 and #8