Add Spinwick type, concept of repeatable vs unique IDs #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note-none
streamer45
reviewed
Jan 9, 2025
streamer45
reviewed
Jan 9, 2025
nickmisasi
changed the title
streamer45
reviewed
Jan 10, 2025
streamer45
approved these changes
Jan 10, 2025
gabrieljackson
approved these changes
Jan 10, 2025
|
Merging so I can rebase my changes. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #67 a new concept of unique Spinwick IDs was introduced to allow support for deletion pending windows. This worked for creation but was problematic for updates, since the same always-unique spinwick ID is assigned as the workspace OwnerID, and couldn't be looked up after creation. This PR adjusts logic so that the 2 types of spinwick IDs can be generated - repeatable, and unique. The former is used for OwnerID, and other lookups, while the latter is used for DNS names.
Ticket Link
N/A
Release Note