-
Notifications
You must be signed in to change notification settings - Fork 417
MSC4377: Clarify Image Pack Ordering #4377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Enovale
wants to merge
4
commits into
matrix-org:main
Choose a base branch
from
Enovale:pack-order
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Enovale marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # MSC4377: Clarify Image Pack Ordering | ||
|
|
||
| ## Dependencies | ||
|
|
||
| This MSC builds on MSC2545 (which at the time of writing have not yet been accepted | ||
| into the spec). | ||
Enovale marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ## Proposal | ||
|
|
||
| To Preface: Within the `m.image_pack.rooms` state event for rooms and account data, `rooms` defines a map between room IDs, and a map between a stateKey and an **empty object**. | ||
|
|
||
| Instead of an **empty object**, this MSC defines this object like so: | ||
Enovale marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - `order` **Optional, String**. Lexicographic ordering key. | ||
|
|
||
| So for example, before: | ||
| ``` | ||
| { | ||
| "rooms": { | ||
| "!NasysSDfxKxZBzJJoE:matrix.org": { | ||
| "Nonexistent-Stickers": {} | ||
| }, | ||
| } | ||
| } | ||
| ``` | ||
| After: | ||
| ``` | ||
| { | ||
| "rooms": { | ||
| "!NasysSDfxKxZBzJJoE:matrix.org": { | ||
| "Nonexistent-Stickers": { | ||
| "order": "abcd" | ||
| } | ||
| }, | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### Sorting | ||
|
|
||
| Clients can continue to use the image pack source priority defined in MSC2545, but within the sources that utilize `m.image_pack.rooms`, clients should sort the packs lexicographically by the `order` field. | ||
|
|
||
| This sorting should be done WITHIN the packs in each `m.image_pack.rooms` event, e.g. room-local packs should NOT appear before user-account-local packs, if following the suggested pack source priority. | ||
|
|
||
| ## Known Limitations | ||
|
|
||
| This MSC does not specify or support an `order` field when no state keys are specified, which translates to "*all image packs that a room defines*". It is expected that the pack source is redefined with state keys for each image pack if the user wants to reorder packs within a single pack source. | ||
|
|
||
| # Security considerations | ||
|
|
||
| There are no obvious security concerns with this MSC. | ||
|
|
||
| ## Unstable prefix | ||
|
|
||
| Until this proposal is accepted into the spec, implementations SHOULD refer to `order` as `com.enovale.msc4377.order`. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation requirements:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly are you suggesting as a change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a suggestion, it's just documentation for what is roughly required before the MSC can be considered for final comment period