feat(crypto-js): Implement key verification #788
Conversation
Codecov ReportBase: 80.30% // Head: 80.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
=======================================
Coverage 80.30% 80.30%
=======================================
Files 115 115
Lines 16064 16064
=======================================
Hits 12900 12900
Misses 3164 3164
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hywan
force-pushed
the
feat-wasm-js-verification
branch
from
6a29441 to
2da3291
Compare
Hywan
force-pushed
the
feat-wasm-js-verification
branch
2 times, most recently
from
ca18f23 to
d12d48d
Compare
|
Blocked by #1018. |
Hywan
force-pushed
the
feat-wasm-js-verification
branch
from
ce022e4 to
1d6fe48
Compare
Hywan
force-pushed
the
feat-wasm-js-verification
branch
from
ef33e58 to
4c4fcf9
Compare
| @@ -0,0 +1,80 @@ | |||
| const { DeviceLists, RequestType, KeysUploadRequest, KeysQueryRequest } = require('../pkg/matrix_sdk_crypto_js'); | |||
|
|
|||
| function* zip(...arrays) { | |||
There was a problem hiding this comment.
what's that function* notation? What does that mean? Not seen that in JS before!?!
There was a problem hiding this comment.
It's used to declare a Generator, with yield to produce a value.
|
Thanks for the review @gnunicorn! |
|
And a special thanks to @poljar for the help with the unit tests! |
Related to #1016.
This PR is quite important. It brings the Key Verification API to
crypto-js, aka SAS, Emoji, QR Code and bootstraping cross stuff.Progression
OlmMachine.get_user_devices(imply supporting aUserDevicestype),OlmMachine.get_device(imply supporting aDevicetype),OlmMachine.get_verification(imply supporting aVerificaftiontype),OlmMachine.get_verification_requestand.get_verification_requests(imply supporting aVerificationRequesttype),OlmMachine.receive_unencrypted_verification_event,Verification,VerificationRequest,Sas,EmojiQr,QrCode,CancelInfo,CancelCode,DeviceKey,Device,LocalTrust,UserDevices.