Skip to content

Conversation

@jmartinesp
Copy link
Contributor

Closes #5839

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@jmartinesp jmartinesp force-pushed the feat/add-manage-rooms-in-space-power-level branch from 95c6ecf to 95190ea Compare November 11, 2025 16:39
@stefanceriu stefanceriu self-requested a review November 11, 2025 16:41
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 11, 2025

CodSpeed Performance Report

Merging #5857 will not alter performance

Comparing feat/add-manage-rooms-in-space-power-level (0e44b20) with main (1db4a4c)

Summary

✅ 50 untouched

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.60%. Comparing base (a3424a7) to head (0e44b20).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/room/power_levels.rs 86.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5857   +/-   ##
=======================================
  Coverage   88.59%   88.60%           
=======================================
  Files         362      362           
  Lines      102324   102339   +15     
  Branches   102324   102339   +15     
=======================================
+ Hits        90654    90674   +20     
+ Misses       7448     7442    -6     
- Partials     4222     4223    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ve it match the other fields which take after their underlying state event name.
@stefanceriu stefanceriu marked this pull request as ready for review November 13, 2025 06:58
@stefanceriu stefanceriu requested a review from a team as a code owner November 13, 2025 06:58
@stefanceriu stefanceriu enabled auto-merge (squash) November 13, 2025 07:05
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to rename manage_rooms_in_space to space_child but otherwise lgtm 👍

@stefanceriu stefanceriu merged commit f702364 into main Nov 13, 2025
52 checks passed
@stefanceriu stefanceriu deleted the feat/add-manage-rooms-in-space-power-level branch November 13, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose m.space.child permission value from RoomPowerLevelsValues

3 participants