Skip to content

feat(timeline): handle live aggregations on non-live timelines #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented May 19, 2025

This makes it possible to handle reactions/redactions/edits/etc. on non-live timelines. As a result, the pinned and focused timelines will now get live reactions/redactions and so on. This makes it possible to also have the thread timelines handle those live events, although it's unclear how it will pane out in the end, when the event cache is also involved.

Fixes #4823.
Fixes #4643.
Part of #4869.

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 55.91398% with 41 lines in your changes missing coverage. Please review.

Project coverage is 85.84%. Comparing base (6f8b744) to head (746bbca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dk-ui/src/timeline/controller/state_transaction.rs 45.07% 39 Missing ⚠️
...rates/matrix-sdk-ui/src/timeline/controller/mod.rs 85.71% 1 Missing ⚠️
...tes/matrix-sdk-ui/src/timeline/controller/state.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5060      +/-   ##
==========================================
- Coverage   85.90%   85.84%   -0.06%     
==========================================
  Files         325      325              
  Lines       35943    36027      +84     
==========================================
+ Hits        30876    30927      +51     
- Misses       5067     5100      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bnjbvr bnjbvr force-pushed the bnjbvr/timeline-pinned-events-live-edits2 branch from 0dfc334 to bd83937 Compare May 20, 2025 12:31
@bnjbvr bnjbvr marked this pull request as ready for review May 20, 2025 12:31
@bnjbvr bnjbvr requested a review from a team as a code owner May 20, 2025 12:31
@bnjbvr bnjbvr requested review from andybalaam and removed request for a team May 20, 2025 12:31
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bnjbvr bnjbvr merged commit a98f71e into main May 20, 2025
41 of 42 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/timeline-pinned-events-live-edits2 branch May 20, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants