-
Notifications
You must be signed in to change notification settings - Fork 289
feat: implement and observe MSC4278 config value #5040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e4b7fe8
to
eb2186a
Compare
eb2186a
to
dddff85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5040 +/- ##
==========================================
- Coverage 85.85% 85.82% -0.04%
==========================================
Files 325 325
Lines 35937 35988 +51
==========================================
+ Hits 30855 30887 +32
- Misses 5082 5101 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, there are some missing docs here an there.
It would have been nice if this was spit out into separate commits. There are clear separation points. For example the extending of the mocking server could have been one commit, the functionality in the SDK a second one, and finally the bindings the third one.
But ok, it's not that big of a PR so it's still reviewable without this separation. Just something to keep in mind.
dddff85
to
00ab99a
Compare
I see you have force pushed to implement the requested changes. Please refrain in the future from doing so, it makes the subsequent review rounds harder. Our contributing guide explains the preferred review process: https://github.com/matrix-org/matrix-rust-sdk/blob/main/CONTRIBUTING.md#review-process. |
85c05c7
to
602eef4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still some docs missing and I just realized that there's going to be a small race.
Looks almost ready to be merged.
I know that I complained about force pushes, but now the CI is broken unless you rebase onto main.
So feel free to do that.
602eef4
to
2e26cf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now.
This PR
Default
for the content type