-
Notifications
You must be signed in to change notification settings - Fork 290
fix(ui): Introduce Timeline
regions
#5000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hywan
merged 18 commits into
matrix-org:main
from
Hywan:fix-ui-timeline-insert-end-with-timelinestart
May 12, 2025
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c012d12
fix(ui): Offset the timeline index in the presence of a `TimelineStart`.
Hywan b3ca0a4
test: Add assert messages in the `assert_timeline_stream` macro.
Hywan cfc50dc
test(ui): Support `index [$nth] --- date divider ---` in `assert_time…
Hywan 3871ddf
test(ui): Add a regression test.
Hywan d30dfec
refactor(ui): Add `ObservableItemsTransaction::push_timeline_start_if…
Hywan 0b73f52
refactor(ui): Add `ObservableItemsTransaction::push_local`.
Hywan a5d9eec
refactor(ui): Add `ObservableItemsTransaction::has_local`.
Hywan f8967b2
chore(base): Move the `bitflags` dependency in the workspace.
Hywan 43dbce5
feat(ui): Define _regions_ in the `Timeline`.
Hywan af465fc
refactor(ui): `DateDividerAdjuster` works on _remotes_ and _locals_ r…
Hywan ec09b40
refactor(ui): `ReadReceiptTimelineUpdate` works on _remotes_ region.
Hywan 9092f44
refactor(ui): `TimelineMetadata` works on the _remotes_ region.
Hywan 52b8ac0
refactor(ui): `TimelineStateTransaction` works on _remotes_ and _all_…
Hywan 0122d11
refactor(ui): `EventHandler` uses regions to improve the code and avo…
Hywan 29ae0eb
chore(ui): Make Clippy happy.
Hywan d108829
doc(ui): Add #5000 in the `CHANGELOG.md`.
Hywan b7149b0
test(ui): Add tests for `push_local` and `push_date_divider`.
Hywan 4b0a2e6
doc(ui): Fix a typo in a comment.
Hywan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.