feat(crypto): Add new encrypt_and_send_custom_to_device to the client
#4998
+502
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4998 +/- ##
=======================================
Coverage 85.85% 85.85%
=======================================
Files 325 325
Lines 35937 35937
=======================================
+ Hits 30852 30853 +1
+ Misses 5085 5084 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BillCarsonFr
force-pushed
the
valere/crypto/to_device_encrypt_helper
branch
from
d4c0e90 to
c27cdd2
Compare
BillCarsonFr
force-pushed
the
valere/crypto/to_device_encrypt_helper
branch
from
c27cdd2 to
2e746c0
Compare
1 task
BillCarsonFr
requested review from
stefanceriu and
richvdh
and removed request for
a team
poljar
reviewed
May 8, 2025
toger5
reviewed
May 9, 2025
crates/matrix-sdk/src/client/mod.rs
Outdated
| #[cfg(feature = "e2e-encryption")] | ||
| pub async fn encrypt_and_send_custom_to_device( | ||
| &self, | ||
| targets: Vec<&Device>, |
There was a problem hiding this comment.
We call it targets here but devices and , recipient_devices` in other places. Is there potential to make it more consistent or are there other reasons why its different?
poljar
requested changes
May 16, 2025
Thx for the reviews and comments. I have updated the PR to adress the comments. I also added a changelog entry |
poljar
requested changes
May 19, 2025
poljar
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a follow-up PR to extract the mock helpers with the other mock helpers, see #5005
Signed-off-by: