Skip to content

[TestRunner] Toger5/widget to device with encryption #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Apr 30, 2025

This pr just runs the test because it is against main. It is the same code as in: #4992
but that wont run tests since its a follow up PR on top of: #4963

  • Public API changes documented in changelogs (optional)

Signed-off-by:

toger5 added 11 commits April 30, 2025 12:52
A new widget filter is required to add support for to-device events.
This allows to let the widget only send and receive to-device events it has negotiated capabilities for.
It consists of the following changes:
 - add a `NotifyNewToDeviceEvent` ToWidget request (a request that will be sent to the widget from the client when the client receives a widget action over the widget api)
 - add the `SendToDeviceRequest` (driver request that will be sent from the widget and asks the driver to send a ToDevice event)
 - add the ToDeviceActions to the required enums: `IncomingMessage`(machine), `MatrixDriverResponse`, `FromWidgetResponse`, `FromWidgetRequest`, `MatrixDriverRequestData`
… events via cs api)

This also hooks up the widget via the machine actions. And adds toDevice events to the subscription.
…sending events via cs api) This also hooks up the widget via the machine actions. And adds toDevice events to the subscription.
…ity.

This needs to be part of the send/read capabilities so that to-device keys can be used.
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 82.42424% with 29 lines in your changes missing coverage. Please review.

Project coverage is 85.88%. Comparing base (284db61) to head (35501df).

Files with missing lines Patch % Lines
crates/matrix-sdk/src/widget/matrix.rs 76.84% 22 Missing ⚠️
crates/matrix-sdk/src/widget/machine/mod.rs 85.18% 4 Missing ⚠️
crates/matrix-sdk/src/widget/machine/driver_req.rs 71.42% 2 Missing ⚠️
crates/matrix-sdk/src/widget/filter.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4993      +/-   ##
==========================================
+ Coverage   85.86%   85.88%   +0.02%     
==========================================
  Files         325      325              
  Lines       35851    36002     +151     
==========================================
+ Hits        30783    30922     +139     
- Misses       5068     5080      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toger5 toger5 force-pushed the toger5/widget-to-device-with-encryption branch from 7ccafd4 to 35501df Compare May 2, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant