feat(send_queue): Implement sending of MSC4274 galleries #4977
+1,363
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Marbach <[email protected]>
Johennes
force-pushed
the
johannes/msc4274-step2
branch
from
ba8aa4b to
0c3161b
Compare
Johennes
commented
Apr 25, 2025
Comment on lines
+2325
to
+2334
| let info = assign!(info.map(ImageInfo::from).unwrap_or_default(), { | ||
| mimetype: Some(content_type.as_ref().to_owned()), | ||
| thumbnail_source, | ||
| thumbnail_info | ||
| }); | ||
| let content = assign!(ImageMessageEventContent::new(body, source), { | ||
| info: Some(Box::new(info)), | ||
| formatted: formatted_caption, | ||
| filename | ||
| }); |
There was a problem hiding this comment.
These blocks could maybe share the logic with make_attachment_type by extracting a function to create the content for each mime-type? I wasn't sure if it's really worth it because it might not be shorter due to the number of arguments on the call.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4977 +/- ##
==========================================
+ Coverage 85.91% 85.94% +0.02%
==========================================
Files 325 325
Lines 35697 35699 +2
==========================================
+ Hits 30670 30681 +11
+ Misses 5027 5018 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm mindful that it's probably just a matter of lack of time but if there's anything I can do to simplify reviewing this PR, I'd be happy to follow any suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken out of #4838 and is a step towards implementing MSC4274.
RoomSendQueue::send_gallerywas added to handle the sending of galleriesDependentQueuedRequestKind::FinishGalleryhandels the sending of the final eventRoom::make_attachment_eventwas renamed tomake_message_eventbecause it is now reused to create gallery events as wellThis is relatively large, unfortunately, but including everything needed to actually send the event made it possible to also add a test for it. It would be nice if the amount of new code could be reduced but I'm struggling a bit to find ways to integrate galleries with the existing media uploads further.