refactor(sdk): compute a push context only once when computing push actions for a bunch of events #4962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has three benefits:
try_decrypt_event()
for lots of events (which can happen when doing/context
queries).PushContext
, and use that to compute the push actions after decrypting/messages
at the right time (inself.try_decrypt_event
), so we don't need to do it in an extra processing stepThis is a preparatory refactoring for threads, since we'll want to use similar logic when fetching the thread roots, or when back-paginating inside a thread.
Part of #4869.