Skip to content

multiverse: Add a command to invite users to a room #4944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Apr 16, 2025

This closes #4509.

@poljar poljar requested a review from a team as a code owner April 16, 2025 13:01
@poljar poljar requested review from bnjbvr and removed request for a team April 16, 2025 13:01
@poljar poljar force-pushed the poljar/multiverse-invite-sending branch from 43a7739 to 300b011 Compare April 16, 2025 13:06
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (bc50cae) to head (22446fa).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4944   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files         324      324           
  Lines       35614    35614           
=======================================
  Hits        30603    30603           
  Misses       5011     5011           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Comment on lines +53 to +56
// Clap expects the first argument to be the binary name, like when a command is
// invoked on the command line. Since we aren't a command line, but
// still find clap a neat command parser, let's give it what it
// expects so we can parse our commands.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious hack here.

@poljar poljar force-pushed the poljar/multiverse-invite-sending branch from a52725b to 22446fa Compare April 17, 2025 09:48
@poljar poljar enabled auto-merge (rebase) April 17, 2025 09:57
@poljar poljar merged commit a848506 into main Apr 17, 2025
41 checks passed
@poljar poljar deleted the poljar/multiverse-invite-sending branch April 17, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiverse: support sending room invites to other users
2 participants