Skip to content

feat(event cache): don't strip a bundled thread relation when storing it in the event cache #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Apr 15, 2025

We may be reusing the bundled thread info as a location where to save the thread summary in a near future, so it's useful to keep it from sync, for the sake of our experiments.

Part of #4869.

… it in the event cache

We may be reusing the bundled thread info as a location where to save
the thread summary in a near future, so it's useful to keep it from
sync, for the sake of our experiments.
@bnjbvr bnjbvr requested a review from a team as a code owner April 15, 2025 15:28
@bnjbvr bnjbvr requested review from Hywan and removed request for a team April 15, 2025 15:28
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.83%. Comparing base (a27d6e2) to head (783ba1d).
Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/event_cache/room/mod.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4941      +/-   ##
==========================================
+ Coverage   85.82%   85.83%   +0.01%     
==========================================
  Files         323      323              
  Lines       35512    35514       +2     
==========================================
+ Hits        30478    30485       +7     
+ Misses       5034     5029       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bnjbvr bnjbvr marked this pull request as draft April 15, 2025 16:33
@bnjbvr
Copy link
Member Author

bnjbvr commented Apr 15, 2025

Drafting; need to think about it a bit more.

@bnjbvr bnjbvr removed the request for review from Hywan April 15, 2025 16:34
@bnjbvr
Copy link
Member Author

bnjbvr commented Apr 24, 2025

Not the right direction: we'll use a separate ThreadsSummary for more flexibility.

@bnjbvr bnjbvr closed this Apr 24, 2025
@bnjbvr bnjbvr deleted the bnjbvr/dont-strip-thread-bundled-relation branch May 14, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant