crypto: prep work for sharing room key history bundles #4903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For cases where we don't have a whole `EncryptionSettings`, we need a finer-grained method.
Reduce the size of the tuple that this thing returns by defining a new result type. I haven't put the `share_infos` in the struct, because I'm going to reuse the same struct for another method where `share_infos` aren't needed.
We want to re-use all this logic, so putting it in a separate type will help. Plus I think it's cleaner.
This is only used to indicate missing sessions, and the `code` is no longer used, so let's rename the variant and remove the redundant field.
richvdh
force-pushed
the
rav/history_sharing/upload_bundle_prep
branch
from
374a2e7 to
dc3bd69
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4903 +/- ##
==========================================
+ Coverage 85.69% 85.71% +0.02%
==========================================
Files 309 309
Lines 35398 35415 +17
==========================================
+ Hits 30333 30356 +23
+ Misses 5065 5059 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
poljar
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of non-functional changes in
matrix-sdk-cryptowhich may not make a whole lot of sense on their own, but are enablers for the actual sharing of room key history bundles (#4864). I decided to separate the refactoring work from the functional changes for easeier review.