Skip to content

refactor(send_queue): vectorize media handles on SendHandle #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Apr 7, 2025

This was broken out of #4838 and is a preliminary step towards implementing MSC4274. The media_handles field on SendHandle is turned into a vector so that it can hold handles for several media when upload a gallery later.

  • Public API changes documented in changelogs (optional)

@Johennes Johennes marked this pull request as ready for review April 7, 2025 18:32
@Johennes Johennes requested a review from a team as a code owner April 7, 2025 18:32
@Johennes Johennes requested review from poljar and removed request for a team April 7, 2025 18:32
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.71%. Comparing base (5753ca3) to head (64bf57e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/send_queue/mod.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4898   +/-   ##
=======================================
  Coverage   85.70%   85.71%           
=======================================
  Files         309      309           
  Lines       35387    35389    +2     
=======================================
+ Hits        30330    30332    +2     
  Misses       5057     5057           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Approving. Thanks for your patch!

@Hywan Hywan merged commit 056d4a7 into matrix-org:main Apr 8, 2025
48 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants