Skip to content

fix(ffi): propagate the back-pagination status immediately after a subscriber asked for it #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Mar 19, 2025

And add more logs to the event cache computation of the reached_start value.

Might be a reason why we ran into element-hq/element-x-ios#3768: spawning the task can be deferred a bit, so EXI doesn't receive the initial value until much later, causing it to be confused as its initial value was timelineEndReached (it's been changed here, which should also be sufficient to fix the issue).

Part of #3280.

@bnjbvr bnjbvr requested a review from a team as a code owner March 19, 2025 17:14
@bnjbvr bnjbvr requested review from andybalaam and stefanceriu and removed request for a team March 19, 2025 17:14
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.45%. Comparing base (a0eb934) to head (c628206).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4818   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files         297      297           
  Lines       34559    34565    +6     
=======================================
+ Hits        29877    29883    +6     
  Misses       4682     4682           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bnjbvr bnjbvr merged commit 5acaaf5 into main Mar 20, 2025
43 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/bug-fixing-extraordinaire-the-return branch March 20, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants