Skip to content

doc(sdk): Precise in which context a variable can or cannot be used #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

doc(sdk): Precise in which context a variable can or cannot be used #4811

merged 1 commit into from
Mar 19, 2025

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Mar 18, 2025 •
edited
Loading

@Hywan Hywan requested a review from a team as a code owner March 18, 2025 16:45
@Hywan Hywan requested review from andybalaam and removed request for a team March 18, 2025 16:45
@Hywan Hywan force-pushed the refactor-event-cache-clarify-reached-start branch from f0631bc to 54db5cf Compare March 18, 2025 16:50
@Hywan Hywan changed the title refactor(sdk): Move reached_start closer to where it is used doc(sdk): Precise in which context a variable can or cannot be used Mar 18, 2025
bnjbvr
bnjbvr approved these changes Mar 18, 2025
View reviewed changes
crates/matrix-sdk/src/event_cache/room/mod.rs
@@ -922,6 +922,9 @@ mod private {

// We've reached the start on disk, if and only if, there was no chunk prior to
// the one we just loaded.
//
// This value is correct, if and only if, it is used for a chunk content of kind
// `Items`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could even say events :)

@codecov Codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (914b712) to head (54db5cf).
Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4811      +/-   ##
==========================================
- Coverage   86.41%   86.40%   -0.01%     
==========================================
  Files         296      296              
  Lines       34486    34486              
==========================================
- Hits        29800    29799       -1     
- Misses       4686     4687       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hywan Hywan merged commit 82ef623 into matrix-org:main Mar 19, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjbvr bnjbvr bnjbvr approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hywan @bnjbvr