test(common): Ensure inserting a new first chunk is as expected #4810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
test-common-linked-chunk-lazy-loader-more-assert
branch
from
883edc6 to
c0787d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4810 +/- ##
=======================================
Coverage 86.41% 86.41%
=======================================
Files 296 296
Lines 34486 34490 +4
=======================================
+ Hits 29800 29806 +6
+ Misses 4686 4684 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bnjbvr
approved these changes
Mar 19, 2025
…ew first chunk. This patch adds a new check when inserting a new first chunk. It makes some tests to fail but because they were not realistic. This patch then updates these tests.
Hywan
force-pushed
the
test-common-linked-chunk-lazy-loader-more-assert
branch
from
c0787d1 to
351815b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
debug_assert_eqto ensure the new first chunk is the one that matches thelazy_previousof the current first chunk.EventCachestorage #3280