chore(ui): Extract TimelineBuilder tasks into their own functions
#4796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
commented
Mar 12, 2025
Hywan
force-pushed
the
chore-ui-timeline-builder-tasks
branch
from
4a72319 to
3780e44
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4796 +/- ##
==========================================
- Coverage 86.39% 86.34% -0.05%
==========================================
Files 291 291
Lines 34365 34383 +18
==========================================
- Hits 29690 29689 -1
- Misses 4675 4694 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This patch moves the task responsibles to handle the `RoomEventCacheUpdate`s into its own function. The goal is to get simpler code.
…ion. This patch moves the task responsibles to handle the pinned event IDs stream into its own function. The goal is to get simpler code.
This patch moves the task responsibles to handle the `RoomSendQueueUpdate`s into its own function. The goal is to get simpler code.
…ion. This patch moves the task responsibles to handle the room keys from backups into its own function. The goal is to get simpler code.
This patch moves the task responsibles to handle the `BackupState` updates into its own function. The goal is to get simpler code.
This patch moves the task responsibles to handle the `RoomKeyInfo` updates into its own function. The goal is to get simpler code.
This patch moves an inline comment in its correct place. Code was inserted between the comment and the part of the code it was documenting.
Hywan
force-pushed
the
chore-ui-timeline-builder-tasks
branch
from
3780e44 to
68db84d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #4794.
This patch rewrites the
TimelineBuilder::build()method by extracting all the spawned task code block into their own function. The resulting code is simpler to read, and we can reference each task by its function name. Moreover, each task is isolated, it's a bit easier to reason about.