fix(event cache): don't remove a gap when it's the only chunk in memory #4779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we know which room some logs messages correspond to.
`.not()` is useful in assertions, at best, but using it where `!` would suffice is a bad code smell.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4779 +/- ##
==========================================
- Coverage 86.34% 86.34% -0.01%
==========================================
Files 291 291
Lines 34233 34245 +12
==========================================
+ Hits 29560 29570 +10
- Misses 4673 4675 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 11, 2025
bnjbvr
force-pushed
the
bnjbvr/bug-fixing-extraordinaire
branch
from
cb4bca7 to
c812f0b
Compare
bnjbvr
force-pushed
the
bnjbvr/bug-fixing-extraordinaire
branch
from
c812f0b to
443bb96
Compare
Hywan
approved these changes
Mar 11, 2025
| // Replace the gap with the events we just deduplicated. | ||
| room_events.replace_gap_at(reversed_events.clone(), gap_id) | ||
| .expect("gap_identifier is a valid chunk id we read previously") | ||
| assert!(events.is_empty()); |
There was a problem hiding this comment.
Shouldn't it be reversed_events for the sake of clarity?
There was a problem hiding this comment.
both are the same, right?
There was a problem hiding this comment.
you're right it's better 👍
| it.next().is_none() | ||
| }; | ||
|
|
||
| let next_pos = if events.is_empty() && !has_only_one_chunk { |
| @@ -1915,6 +1915,27 @@ mod tests { | |||
| let chunks = store.load_all_chunks(room_id).await.unwrap(); | |||
| assert!(chunks.is_empty()); | |||
|
|
|||
| // Check that cascading worked. Yes, sqlite, I doubt you. | |||
| // enabled on a per-connection basis. Execute it every time we try to get a | ||
| // connection, since we can't guarantee a previous connection did | ||
| // enabled it before. | ||
| connection.execute_batch("PRAGMA foreign_keys = ON;").await?; |
| }) | ||
| { | ||
| if user_ids != prev_user_ids { | ||
| self.ignore_user_list_changes.set(user_ids); |
There was a problem hiding this comment.
It may be a good use case for update_if here, though it's not blocking the approval of this patch.
There was a problem hiding this comment.
think update_if would trigger an update the first time it's set to a non default value, right? or we'd need to initialize the ignore_user_list_changes with an initial value without having it trigger, or something? might be nice actually, but yeah, follow up
… chunk in memory A linked chunk never wants to be empty. However, after a limited gap that doesn't contain events, it may be shrunk to the latest chunk that's a gap. If later we decide to remove the gap (because it's been resolved with no events), then we would try to remove the last chunk, which is not correct. Ideally, we'd keep an events chunk around; but if we have an events chunk *before* a gap, that may look like missing events to the user, at least until the gap has been resolved. The fix to this problem is to *not* optimize / remove the gap, if it's the only chunk kept in memory. This was only a memory optimization, but it's not absolutely required per se.
As opposed to WAL mode, foreign keys must be enabled for each database connection, according to https://www.sqlite.org/foreignkeys.html#fk_enable Unfortunately, we can't track which connection objects have already executed the pragma, so the safer we can do is enable it everytime we try to acquire a connection from the pool. Fixes #4785.
…anged since the previous time
bnjbvr
force-pushed
the
bnjbvr/bug-fixing-extraordinaire
branch
from
443bb96 to
b60736c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for more explanations. This makes the event cache much more stable for
multiverse, by addressing three issues:Bugs found with
multiverse.Fixes #4785.
Fixes #4784.
Part of #3280.