Skip to content

feat(ffi): allow clearing all the non-critical caches + set a media retention policy #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Mar 3, 2025

What it says on the tin.

Part of #3280.

@bnjbvr bnjbvr requested a review from a team as a code owner March 3, 2025 15:22
@bnjbvr bnjbvr requested review from andybalaam and removed request for a team March 3, 2025 15:22
@bnjbvr
Copy link
Member Author

bnjbvr commented Mar 3, 2025

So long for the async closures 🥹

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (5fd0cb0) to head (663bd9f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4745      +/-   ##
==========================================
- Coverage   86.14%   86.14%   -0.01%     
==========================================
  Files         292      292              
  Lines       34301    34299       -2     
==========================================
- Hits        29550    29548       -2     
  Misses       4751     4751              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr
Copy link
Member Author

bnjbvr commented Mar 4, 2025

Note: bumped the MSRV too, added a changelog entry.

@bnjbvr bnjbvr enabled auto-merge (rebase) March 4, 2025 17:04
@bnjbvr bnjbvr merged commit bffb19b into main Mar 4, 2025
44 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/ffi-clear-cache branch March 4, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants