fix: RoomEventCache::subscribe is now infallible
#4660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates `RoomEventCache::subscribe` to be infallible. This method wasn't able to return something else than an `Ok`. The return type has been updated from `Result<T>` to `T`.
Hywan
force-pushed
the
refactor-sdk-room-event-cache-subscribe-is-infallible
branch
from
d07be2e to
41e6889
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4660 +/- ##
==========================================
+ Coverage 85.69% 85.71% +0.01%
==========================================
Files 292 292
Lines 33620 33618 -2
==========================================
+ Hits 28812 28817 +5
+ Misses 4808 4801 -7 ☔ View full report in Codecov by Sentry. |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
RoomEventCache::subscribeto be infallible. This method wasn't able to return something else than anOk. The return type has been updated fromResult<T>toT.EventCachelazy-loading #4632