refactor(common): LinkedChunk can start by a gap
#4653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
requested review from
stefanceriu and
bnjbvr
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4653 +/- ##
==========================================
+ Coverage 85.68% 85.69% +0.01%
==========================================
Files 292 292
Lines 33570 33600 +30
==========================================
+ Hits 28763 28794 +31
+ Misses 4807 4806 -1 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Feb 11, 2025
This patch removes the invariant stating that a `LinkedChunk` must start by a chunk of type items. This has never been really useful but it's now annoying to have this (with iterative loading of a `LinkedChunk` via the `EventCache`, it's now possible to get a gap as the first chunk). Let's remove this invariant.
This patch splits the `test_replace_at` test into 3 smaller tests.
This patch updates the `test_replace_item` test to ensure `Update::ReplaceItem` is correct.
This patch splits the `test_insert_items_at` test into 5 tests.
Hywan
force-pushed
the
feat-common-linked-chunk-can-start-by-a-gap
branch
from
e29958f to
74f927b
Compare
|
I've improved the comments a bit. I've also split the |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the invariant stating that a
LinkedChunkmust start by a chunk of type items. This has never been really useful but it's now annoying to have this (with iterative loading of aLinkedChunkvia theEventCache, it's now possible to get a gap as the first chunk). Let's remove this invariant.EventCachestorage #3280EventCachelazy-loading #4632