test(sdk): Improve the test suite of RoomEvents
#4172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4172 +/- ##
==========================================
+ Coverage 84.77% 84.79% +0.02%
==========================================
Files 269 269
Lines 28963 28963
==========================================
+ Hits 24552 24560 +8
+ Misses 4411 4403 -8 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Oct 28, 2024
This patch adds an `Event` type alias to `SyncTimelineEvent` to (i) make the code shorter, (ii) remove some cognitive effort, (iii) make things more convenient.
This patch adds unit tests for the `RoomEvents`' methods.
Hywan
force-pushed
the
test-sdk-event-cache-room-events
branch
from
0a2272e to
196dabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should be reviewed commit-by-commit. The idea is to improve the test suite of
RoomEvents.EventCachestorage #3280