Store the timeline in the SledStore #141
Conversation
| @@ -529,6 +527,19 @@ impl BaseClient { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: | |||
| // We wait until after the event has been decrypted? | |||
There was a problem hiding this comment.
Sorry what are you asking here? The block above already makes sure that all events that can be decrypted during this sync are decrypted.
There was a problem hiding this comment.
Yeah I was just making sure that we wanted the events decrypted I figured since the Store can be encrypted that this is Ok but I just wanted to make sure.
| resp: &api::message::get_message_events::Response, | ||
| ) -> Result<()> { | ||
| let mut changes = StateChanges::default(); | ||
| changes.handle_messages_response(room_id, resp, dir); |
There was a problem hiding this comment.
This method will need to decrypt the events as well, but that can be left for later on.
|
|
||
| // A key consists of `RoomId` | ||
| let mut key = rid.as_bytes().to_vec(); | ||
| key.push(0xff); |
There was a problem hiding this comment.
Let's not do this, we have the EncodeKey trait for this. Every key or tuple of keys should go through an encode() call.
There was a problem hiding this comment.
Yea that was mostly just me working through the larger problem. I was planning on adding EncodeKey trait for whatever tuples we need e.g. ((&str, u128, whatever)). Sound good?
| ret?; | ||
|
|
||
| for (rid, room) in &changes.sync_timeline { |
There was a problem hiding this comment.
Small nit, let's use room_id or (room, room_events) like the rest of the code here.
|
Closing in favor of #486 . |
May resolve #138
So this is SUPER work in progress just wanted to have a place to look at code and try things out...