Skip to content

feat(crypto-js): Implement OlmMachine.export_room_keys and .import_room_keys #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 27, 2022

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Sep 21, 2022

Related to #1016.

Progress

  • Implement InboundGroupSession with a minimal API,
  • Implement OlmMachine.export_room_keys with a predicate (!),
  • Implement OlmMachine.import_room_keys,
  • Implement OlmMachine.encrypt_room_key_export (static function),
  • Implement OlmMachine.decrypt_room_key_export (static function).

@Hywan Hywan added enhancement New feature or request bindings labels Sep 21, 2022
@Hywan Hywan self-assigned this Sep 21, 2022
@Hywan Hywan requested a review from a team September 22, 2022 09:27
@Hywan Hywan marked this pull request as ready for review September 22, 2022 09:27
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 78.46% // Head: 78.46% // No change to project coverage 👍

Coverage data is based on head (df50a54) compared to base (6be0fc1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   78.46%   78.46%           
=======================================
  Files         110      110           
  Lines       15111    15111           
=======================================
  Hits        11857    11857           
  Misses       3254     3254           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hywan Hywan merged commit f8b02d1 into matrix-org:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants