Skip to content

feat(sdk): Rename (export|import)_keys to (export|import)_room_keys #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 21, 2022

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Sep 21, 2022

More or less related to #1016.

After a discussion with @poljar, we agreed it was necessary to rename some methods and functions, so that it's more explicit about what they do.

This is a set of 4 patches that rename:

  • OlmMachine.export_keys to .export_room_keys,
  • OlmMachine.import_keys to .import_room_keys,
  • encrypt_key_export to encrypt_room_key_export,
  • decrypt_key_export to decrypt_room_key_export.

@Hywan Hywan added the enhancement New feature or request label Sep 21, 2022
@Hywan Hywan requested review from poljar and jplatte September 21, 2022 11:24
@Hywan Hywan self-assigned this Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 78.46% // Head: 78.46% // No change to project coverage 👍

Coverage data is based on head (782b256) compared to base (c0ebeee).
Patch coverage: 92.85% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1058   +/-   ##
=======================================
  Coverage   78.46%   78.46%           
=======================================
  Files         110      110           
  Lines       15111    15111           
=======================================
  Hits        11857    11857           
  Misses       3254     3254           
Impacted Files Coverage Δ
crates/matrix-sdk-crypto/src/lib.rs 100.00% <ø> (ø)
crates/matrix-sdk/src/encryption/mod.rs 37.50% <0.00%> (ø)
...atrix-sdk-crypto/src/file_encryption/key_export.rs 98.49% <100.00%> (ø)
crates/matrix-sdk-crypto/src/machine.rs 81.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Hywan Hywan merged commit 6be0fc1 into matrix-org:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants