Upload device keys during initCrypto #2943
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than waiting for the application to call `.startClient`, upload the device keys during `initCrypto()`. Element-R is going to approach this slightly differently (the rust-sdk wants to manage the decision on key uploads itself), so this lays some groundwork by collecting the libolm-specific bits together.
|
Turns out I already have a PR open for this 🤦 : #2872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than waiting for the application to call
.startClient, upload thedevice keys during
initCrypto(). Element-R is going to approach this slightlydifferently (the rust-sdk wants to manage the decision on key uploads itself),
so this lays some groundwork by collecting the libolm-specific bits together.
This change is marked as an internal change (Task), so will not be included in the changelog.