Repository navigation
sync: bound sliding sync receipts and typing by membership - #730
Open
basnijholt wants to merge 1 commit into
Open
basnijholt wants to merge 1 commit into
basnijholt wants to merge 1 commit into
Conversation
Only collect live typing for joined or peeking users. Apply the same gate to live public receipts, but keep receipts through the retained departure of a former member. Private receipts and account data are unchanged. Assisted-by: MindRoom DevAgent:openai/gpt-6.2-astra <https://github.com/mindroom-ai/mindroom>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The sliding sync typing and receipts extensions collected data for every room in the response, including rooms the user is not in. Users who were invited, had left, or never joined could see who is typing and live public receipts.
Live typing is now collected only for joined or peeking users. The same gate applies to live public receipts, but a former member keeps receipts up to their retained departure, so departure-time extensions are not dropped wholesale. Private receipts and account data are unchanged.
Found through MindRoom. Fork change: mindroom-ai/mindroom-tuwunel#28.
Tests:
sync::v5::extensions::tests::only_joined_and_peeking_rooms_carry_live_typingand receipt cutoff cases. They fail without the fix (typing and receipts after departure are returned).Validation:
nightly-2026-11-03):cargo fmt --all -- --checkpasses.cargo clippy --offline --lockedon the touched crates with--all-targets --all-features -- -D warningspasses.cargo test -p tuwunel_api_client --lib: 176 passed, plus six related integration tests, including retention of receipts from before the departure.Checklist
cargo fmtand satisfies clippy and rustc lints; any allowed lint is justified by an obvious reason or a comment.src/core/config/mod.rsdoc comments and the regeneratedtuwunel-example.tomlis committed. (No config changes.)docs/. (No user-facing docs change.)