Skip to content

32 panels max (up from 10), and update Release Notes #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
####
---

### <a name="v0.12.7a17"></a>v0.12.7a17 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; released 2021-04-23

- <a name="v0.12.7a17"></a>v0.12.7a17 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; merged 2021-04-22
- max panels to 32 (up from 10) ([Issue #377](https://github.com/matplotlib/mplfinance/issues/377))
- <a name="v0.12.7a16"></a>v0.12.7a16 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; merged 2021-04-22
- New plot type **`step`** for step/staircase lines in `mpf.make_addplot()` (Thank you [@pankaj3009](https://github.com/pankaj3009))
- <a name="v0.12.7a15"></a>v0.12.7a15 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; merged 2021-04-22
- Add **`reversal`** parameter to Point and Figure charts. (Thank you [Caleb Coffin](https://github.com/coffincw), for coding up [Issue 368](https://github.com/matplotlib/mplfinance/issues/368))

- <a name="v0.12.7a14"></a>v0.12.7a14 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; merged 2021-04-18<br>
<a name="v0.12.7a13"></a>v0.12.7a13 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; merged 2021-04-18
- Allow **`os.PathLike`** (**`pathlib.Path`**) objects in **`savefig`** (Thank you [Matt Stancliff](https://github.com/mattsta))


### <a name="v0.12.7a12"></a>v0.12.7a12 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; released 2021-04-09

- <a name="v0.12.7a12"></a>v0.12.7a12 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; merged 2021-04-08
Expand Down
2 changes: 1 addition & 1 deletion src/mplfinance/_arg_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def _process_kwargs(kwargs, vkwargs):
return config

def _valid_panel_id(panid):
return panid in ['main','lower'] or (isinstance(panid,int) and panid >= 0 and panid < 10)
return panid in ['main','lower'] or (isinstance(panid,int) and panid >= 0 and panid < 32)

def _scale_padding_validator(value):
if isinstance(value,(int,float)):
Expand Down
8 changes: 4 additions & 4 deletions src/mplfinance/_panels.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ def _build_panels( figure, config ):
Create and return a DataFrame containing panel information
and Axes objects for each panel, etc.

We allow up to 10 panels, identified by their panel id (panid)
which is an integer 0 through 9.
We allow up to 32 panels, identified by their panel id (panid)
which is an integer 0 through 31.

Parameters
----------
Expand Down Expand Up @@ -101,8 +101,8 @@ def _build_panels( figure, config ):
raise ValueError('inferred panel list is missing panels: '+str(missing))

else:
if not isinstance(num_panels,int) or num_panels < 1 or num_panels > 10:
raise ValueError('num_panels must be integer 1 to 10, but is "'+str(volume_panel)+'"')
if not isinstance(num_panels,int) or num_panels < 1 or num_panels > 32:
raise ValueError('num_panels must be integer 1 to 32, but is "'+str(volume_panel)+'"')
pset = range(0,num_panels)

_nones = [None]*len(pset)
Expand Down
2 changes: 1 addition & 1 deletion src/mplfinance/_version.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

version_info = (0, 12, 7, 'alpha', 16)
version_info = (0, 12, 7, 'alpha', 17)

_specifier_ = {'alpha': 'a','beta': 'b','candidate': 'rc','final': ''}

Expand Down