Skip to content

Fix a compile error on Mac OS 15 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duncanpo merged 2 commits into from
Dec 10, 2025
Merged

Fix a compile error on Mac OS 15 #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcb39f7
resolve error found by stricter compiler on MacOS 15
duncanpo Dec 9, 2025
6f2c996
resolve error found by stricter compiler on MacOS 15
duncanpo Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions patches/grpc-mac.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,16 @@ index 0627429f49..60a86853ba 100644


if(gRPC_INSTALL)
diff --git a/src/core/lib/promise/detail/basic_seq.h b/src/core/lib/promise/detail/basic_seq.h
index 663609d419..d5e56019e3 100644
--- a/src/core/lib/promise/detail/basic_seq.h
+++ b/src/core/lib/promise/detail/basic_seq.h
@@ -100,7 +100,7 @@ class BasicSeqIter {
cur_ = next;
state_.~State();
Construct(&state_,
- Traits::template CallSeqFactory(f_, *cur_, std::move(arg)));
+ Traits::template CallSeqFactory<>(f_, *cur_, std::move(arg))); // add angle brackets to avoid compiler error on MacOS 15
return PollNonEmpty();
});
}