Update menu localization IDs (as per our developers' meeting) and sort them#1486
Open
dpvc wants to merge 1 commit into
Open
Update menu localization IDs (as per our developers' meeting) and sort them#1486dpvc wants to merge 1 commit into
dpvc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the localization IDs used by the menu component and sorts the result. The various dialog messages get prefixes based on the dialog, so they sort together. The percentage IDs are removed and are not localized. The
120%is removed from theScalePercentmessage and included as a parameter in order to avoid it being accidentally translated.