Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add type annotations #462

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
Fix some imports
berquist committed Mar 31, 2023

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit 3f3ae5f2f9ae29b86b32cc08375ad0cede3cdace
2 changes: 1 addition & 1 deletion fireworks/scripts/lpad_run.py
Original file line number Diff line number Diff line change
@@ -327,7 +327,7 @@ def get_fw_ids_helper(lp: LaunchPad, args: Namespace, count_only: Union[bool, No
return ids


def get_fws_helper(lp: LaunchPad, ids: Sequence[int], args: Namespace) -> Union[List[int], int, List[Dict[str, Union[str, int, bool]]], Union[str, int, bool]]:
def get_fws_helper(lp: LaunchPad, ids: Sequence[int], args: Namespace) -> Union[int, List[int], List[List[int]]]:
"""Get fws from ids in a representation according to args.display_format."""
fws = []
if args.display_format == "ids":