This repository was archived by the owner on Jan 13, 2025. It is now read-only.
style: Add explanations to tslint:disable comments
#4448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All `tslint:disable:object-literal-sort-keys` comments now include a description that explains why the linter rule needs to be disabled. For the most part, it's to ensure consistent ordering of methods between adapter interfaces and their implementations in the foundation and component. This PR also reorders a few properties in `MDCCheckbox` and `MDCRadio` for consistency.
Codecov Report
@@ Coverage Diff @@
## feat/typescript #4448 +/- ##
================================================
Coverage 99.05% 99.05%
================================================
Files 130 130
Lines 6238 6238
Branches 813 813
================================================
Hits 6179 6179
Misses 58 58
Partials 1 1
Continue to review full report at Codecov.
|
|
All 624 screenshot tests passed for commit 1b27079 vs. |
acdvorak
requested review from
kfranqueiro
and removed request for
patrickrodee
kfranqueiro
approved these changes
Feb 26, 2019
|
All 624 screenshot tests passed for commit e02c5cf vs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
tslint:disable:object-literal-sort-keyscomments now include a description that explains why the linter rule needs to be disabled. For the most part, it's to ensure consistent ordering of methods between adapter interfaces and their implementations in the foundation and component.This PR also reorders a few properties in
MDCCheckboxandMDCRadiofor consistency.Refs #4225