This repository was archived by the owner on Jan 13, 2025. It is now read-only.
chore: Fix regression in MDCChipFoundation.getDimensions()
#4443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #4332 inadvertently broke short-circuit logic and evaluation order. The change caused incorrect ripple size calculations on filter chips without leading icons, which was caught by internal screenshot tests.
patrickrodee
suggested changes
Feb 23, 2019
Codecov Report
@@ Coverage Diff @@
## feat/typescript #4443 +/- ##
===================================================
+ Coverage 99.05% 99.05% +<.01%
===================================================
Files 130 130
Lines 6230 6237 +7
Branches 812 813 +1
===================================================
+ Hits 6171 6178 +7
Misses 58 58
Partials 1 1
Continue to review full report at Codecov.
|
|
All 624 screenshot tests passed for commit 69e87e5 vs. |
|
All 624 screenshot tests passed for commit 297f7c8 vs. |
|
All 624 screenshot tests passed for commit 53f5b73 vs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4332 inadvertently broke short-circuit logic and evaluation order.
The change caused incorrect ripple size calculations on filter chips without leading icons, which was caught by internal screenshot tests.