Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

chore: Fix internal tslint errors #4440

Merged
merged 7 commits into from
Feb 22, 2019

Conversation

acdvorak
Copy link
Contributor

Refs #4225

@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #4440 into feat/typescript will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/typescript    #4440      +/-   ##
===================================================
- Coverage            99.06%   99.05%   -0.02%     
===================================================
  Files                  130      130              
  Lines                 6230     6230              
  Branches               811      812       +1     
===================================================
- Hits                  6172     6171       -1     
- Misses                  57       58       +1     
  Partials                 1        1
Impacted Files Coverage Δ
packages/mdc-tab-indicator/fading-foundation.ts 100% <ø> (ø) ⬆️
packages/mdc-tabs/tab/foundation.ts 100% <ø> (ø) ⬆️
packages/mdc-select/foundation.ts 97.6% <ø> (ø) ⬆️
packages/mdc-textfield/foundation.ts 100% <ø> (ø) ⬆️
packages/mdc-snackbar/foundation.ts 100% <ø> (ø) ⬆️
packages/mdc-top-app-bar/foundation.ts 100% <ø> (ø) ⬆️
packages/mdc-linear-progress/foundation.ts 100% <ø> (ø) ⬆️
packages/mdc-icon-button/foundation.ts 100% <ø> (ø) ⬆️
packages/mdc-dom/ponyfill.ts 100% <ø> (ø) ⬆️
packages/mdc-grid-list/foundation.ts 100% <ø> (ø) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f441f8f...9d38fa2. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 624 screenshot tests passed for commit b51914c vs. feat/typescript! 💯🎉

@acdvorak acdvorak changed the title chore: Selectively disable internal tslint rules chore: Fix internal tslint errors Feb 22, 2019
@mdc-web-bot
Copy link
Collaborator

All 624 screenshot tests passed for commit 9d38fa2 vs. feat/typescript! 💯🎉

@acdvorak acdvorak merged commit b6b6983 into feat/typescript Feb 22, 2019
@acdvorak acdvorak deleted the feat/typescript--internal-tslint branch February 22, 2019 21:25
@kfranqueiro kfranqueiro mentioned this pull request Feb 22, 2019
45 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants