feat(menu): Convert JS to TypeScript #4342

acdvorak · 2019-02-02T00:48:47Z

Refs #4225

…` from properties

…left/right

…to `constants.ts`

…omponents/material-components-web into feat/typescript--menu-surface

…pescript--menu-surface

…cript--menu-surface--menu

codecov-io · 2019-02-06T07:11:06Z

Codecov Report

Merging #4342 into feat/typescript will increase coverage by 0.12%.
The diff coverage is 98.64%.

@@                 Coverage Diff                 @@
##           feat/typescript    #4342      +/-   ##
===================================================
+ Coverage             98.4%   98.52%   +0.12%     
===================================================
  Files                   93       93              
  Lines                 5819     5832      +13     
  Branches               783      789       +6     
===================================================
+ Hits                  5726     5746      +20     
+ Misses                  92       85       -7     
  Partials                 1        1

Impacted Files	Coverage Δ
packages/mdc-menu/index.ts	`100% <100%> (ø)`
packages/mdc-list/index.ts	`98.5% <100%> (ø)`	⬆️
packages/mdc-select/index.js	`98.34% <100%> (ø)`	⬆️
packages/mdc-menu/foundation.ts	`95.38% <96.55%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b28992...4b99848. Read the comment docs.

packages/mdc-menu/foundation.ts

packages/mdc-menu/types.ts

mdc-web-bot · 2019-02-06T07:17:52Z

All 621 screenshot tests passed for commit 2cfb7de vs. feat/typescript! 💯🎉

moog16

looks good - just some minor changes

packages/mdc-menu/README.md

moog16 · 2019-02-06T07:23:55Z

packages/mdc-menu/README.md

-`getParentElement(element: HTMLElement) => ?HTMLElement` | Returns the `.parentElement` element of the `element` provided.
-`getSelectedElementIndex(element: HTMLElement) => number` | Returns the `index` value of the element within the selection group provided, `element` that contains the `mdc-menu-item--selected` class.
+`getElementIndex(element: Element) => number` | Returns the `index` value of the `element`.
+`getParentElement(element: Element) => ?Element` | Returns the `.parentElement` element of the `element` provided.


Also TS lib.dom.d.ts states it is an HTMLElement

/** * Returns the parent element. */ readonly parentElement: HTMLElement | null;

lib.dom.d.ts is wrong 😛

https://dom.spec.whatwg.org/#parent-element

https://developer.mozilla.org/en-US/docs/Web/API/Node/parentElement

moog16 · 2019-02-06T07:27:04Z

packages/mdc-menu/adapter.ts

   */
-  getParentElement(element) {}
+  getParentElement(element: Element): Element | null;


according to TS Node class it is an HTMLElement that is returned

lib.dom.d.ts is wrong 😛

https://dom.spec.whatwg.org/#parent-element

https://developer.mozilla.org/en-US/docs/Web/API/Node/parentElement

ha - ya that makes sense. I would think they want it to be Element. Ok let's leave it for now.

packages/mdc-menu/index.ts

test/unit/mdc-menu/mdc-menu.test.js

test/unit/mdc-menu/menu.foundation.test.js

test/unit/mdc-select/mdc-select-enhanced.test.js

…o `DefaultMenuItemEventDetail`

mdc-web-bot · 2019-02-06T18:18:57Z

All 621 screenshot tests passed for commit e53bd13 vs. feat/typescript! 💯🎉

mdc-web-bot · 2019-02-06T18:21:44Z

All 621 screenshot tests passed for commit 06892e7 vs. feat/typescript! 💯🎉

packages/mdc-menu/types.ts

moog16

one comment about the year. looks good!

mdc-web-bot · 2019-02-06T21:33:29Z

All 621 screenshot tests passed for commit ac33ef4 vs. feat/typescript! 💯🎉

mdc-web-bot · 2019-02-06T21:47:00Z

All 621 screenshot tests passed for commit 4b99848 vs. feat/typescript! 💯🎉

acdvorak and others added 30 commits January 18, 2019 22:33

chore(menu-surface): Convert JS to TypeScript

6324518

Refs #4225

Merge branch 'feat/typescript' into feat/typescript--menu-surface

6b9bdf0

WIP: Remove MDCMenuSurface prefix from type names; remove `readonly…

f8a687a

…` from properties

WIP: Simplify types; replace string props with number for top/bottom/…

07fff99

…left/right

WIP: Replace indexable types on MenuPosition with keyof

a0843b1

WIP: Consolidate width/height properties into MenuSize objects

7e3e6fe

WIP: Rename MenuSize to MenuDimensions

1538325

WIP: Remove obsolete TODOs

913f607

WIP: Remove unnecessary JSDoc annotation

947b90a

WIP: Relocate type annotation

6f3045d

WIP: Remove stray empty comment

f55703f

WIP: Move MenuPosition and MenuDimensions defs from adapter.ts …

ee56995

…to `constants.ts`

fix(infrastructure): add strict: true to tsconfig

ec3b469

fix: add strict: true to tsconfi

96c0514

WIP: Fix linter error

e3c3d50

WIP: Update focusable element types to HTMLElement | SVGElement

b95fcfa

WIP: Strong typing for getTransformPropertyName() return value

5bf6e27

WIP: Style

0f0525d

Merge branch 'feat/typescript--menu-surface' of github.com:material-c…

83429aa

…omponents/material-components-web into feat/typescript--menu-surface

fix: add tsconfig and update packages

e704163

Update foundation.ts

09aae61

Update foundation.ts

fda0f28

fix: update closest from HTMLElement to Element

5075a05

WIP: Fix tslint errors

1811646

fix: remove dups of strict=true

06bb41a

Merge remote-tracking branch 'origin/fix/tsconfigupdate' into feat/ty…

b8ec011

…pescript--menu-surface

WIP: Fix strict mode errors

82eb81e

WIP: Replace most HTMLElement types with Element

54a86ae

WIP: Add MenuDistance type with all properties required

583b87d

WIP: Replace Array.forEach() with for...of

f71d734

acdvorak added 2 commits February 5, 2019 11:28

WIP: Rename old type reference

7219206

WIP: emit<T extends object>()

af4ea8f

acdvorak force-pushed the feat/typescript--menu-surface--menu branch from 90855bb to af4ea8f Compare February 5, 2019 19:29

acdvorak changed the base branch from feat/typescript--menu-surface to feat/typescript February 5, 2019 21:20

acdvorak added 6 commits February 5, 2019 13:25

Merge remote-tracking branch 'origin/feat/typescript' into feat/types…

fde3de0

…cript--menu-surface--menu

Merge branch 'feat/typescript' into feat/typescript--menu-surface--menu

808b1ee

WIP: Add default exports

b4df1f1

WIP: Add TODOs

9cbd989

WIP: Style

b606485

Merge remote-tracking branch 'origin/feat/typescript' into feat/types…

392c52a

…cript--menu-surface--menu

acdvorak removed the do-not-merge label Feb 6, 2019

WIP: Change HTMLElement to Element and fix test failures

2cfb7de

acdvorak commented Feb 6, 2019

View reviewed changes

packages/mdc-menu/foundation.ts Outdated Show resolved Hide resolved

acdvorak commented Feb 6, 2019

View reviewed changes

packages/mdc-menu/types.ts Outdated Show resolved Hide resolved

moog16 suggested changes Feb 6, 2019

View reviewed changes

acdvorak added 3 commits February 6, 2019 09:57

WIP: Remove Closure syntax from README

ec32e03

WIP: Address review comments

e53bd13

WIP: Remove obsolete TODO and rename MenuItemComponentEventDetail t…

06892e7

…o `DefaultMenuItemEventDetail`

moog16 reviewed Feb 6, 2019

View reviewed changes

packages/mdc-menu/types.ts Outdated Show resolved Hide resolved

moog16 approved these changes Feb 6, 2019

View reviewed changes

acdvorak added 2 commits February 6, 2019 13:17

WIP: Update import syntax for consistency

4b99848

acdvorak merged commit dc4e92c into feat/typescript Feb 6, 2019

acdvorak deleted the feat/typescript--menu-surface--menu branch February 6, 2019 22:51

feat(menu): Convert JS to TypeScript #4342

feat(menu): Convert JS to TypeScript #4342

Uh oh!

Conversation

acdvorak commented Feb 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

mdc-web-bot commented Feb 6, 2019

Uh oh!

moog16 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

moog16 Feb 6, 2019

Choose a reason for hiding this comment

Uh oh!

acdvorak Feb 6, 2019

Choose a reason for hiding this comment

Uh oh!

moog16 Feb 6, 2019

Choose a reason for hiding this comment

Uh oh!

acdvorak Feb 6, 2019

Choose a reason for hiding this comment

Uh oh!

moog16 Feb 6, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdc-web-bot commented Feb 6, 2019

Uh oh!

mdc-web-bot commented Feb 6, 2019

Uh oh!

Uh oh!

moog16 left a comment

Choose a reason for hiding this comment

Uh oh!

mdc-web-bot commented Feb 6, 2019

Uh oh!

mdc-web-bot commented Feb 6, 2019

Uh oh!

Uh oh!

acdvorak commented Feb 2, 2019 •

edited

Loading

codecov-io commented Feb 6, 2019 •

edited

Loading