Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

feat(radio): ts conversion #4329

Merged
merged 7 commits into from
Feb 6, 2019
Merged

feat(radio): ts conversion #4329

merged 7 commits into from
Feb 6, 2019

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Jan 31, 2019

related #4225

@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #4329 into feat/typescript will decrease coverage by 0.01%.
The diff coverage is 85%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/typescript    #4329      +/-   ##
===================================================
- Coverage             98.4%   98.39%   -0.02%     
===================================================
  Files                   93       93              
  Lines                 5777     5793      +16     
  Branches               779      782       +3     
===================================================
+ Hits                  5685     5700      +15     
- Misses                  91       92       +1     
  Partials                 1        1
Impacted Files Coverage Δ
packages/mdc-radio/foundation.ts 100% <100%> (ø)
packages/mdc-menu-surface/foundation.ts 100% <100%> (ø) ⬆️
packages/mdc-checkbox/foundation.ts 96.96% <100%> (ø) ⬆️
packages/mdc-ripple/foundation.ts 100% <100%> (ø) ⬆️
packages/mdc-linear-progress/foundation.ts 100% <100%> (ø) ⬆️
packages/mdc-radio/index.ts 85.71% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2befa88...00b4c3f. Read the comment docs.

@kfranqueiro kfranqueiro mentioned this pull request Jan 31, 2019
45 tasks
@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 3299f56 vs. feat/typescript! 💯🎉

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acdvorak acdvorak self-assigned this Feb 6, 2019
@moog16
Copy link
Contributor Author

moog16 commented Feb 6, 2019

@acdvorak thanks for fixing everything for me! 👍

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 00b4c3f vs. feat/typescript! 💯🎉

@moog16 moog16 merged commit 90f5f05 into feat/typescript Feb 6, 2019
@moog16 moog16 deleted the feat/radio-ts branch February 6, 2019 02:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants