Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

fix(infrastructure): remove babel loader #4321

Closed
wants to merge 3 commits into from

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Jan 30, 2019

related #4225

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fail npm run build:min whereas the existing config passes. Can we figure out why?

@moog16 moog16 force-pushed the feat/remove-babel-loader-ts branch from ecf709f to c79366d Compare January 31, 2019 18:11
@moog16
Copy link
Contributor Author

moog16 commented Jan 31, 2019

we should have travis run this step. It looks like npm run dist covers both build/build:min. But on 2nd thought it would be nicer to see both build and build:min separately. I can open a PR to update.

@kfranqueiro
Copy link
Contributor

Unit tests are also failing in IE11 due to a syntax error. I don't think we can completely remove babel-loader while we still have ES6-formatted unit tests...

It also occurs to me that even for purposes of just the typescript sources, we probably can't actually remove babel-loader until we remove all occurrences of Object.assign, which probably means we need to wait until after all of the modules are converted to typescript.

@moog16
Copy link
Contributor Author

moog16 commented Feb 6, 2019

I added back the babel loader for js files. I believe it to be unnecessary to have it in both places (ts files and js files`

@moog16 moog16 force-pushed the feat/remove-babel-loader-ts branch from 7d7238a to ce2cea3 Compare February 6, 2019 07:18
@moog16
Copy link
Contributor Author

moog16 commented Feb 15, 2019

closing this PR...more to come in #4409

@moog16 moog16 closed this Feb 15, 2019
@moog16 moog16 deleted the feat/remove-babel-loader-ts branch June 28, 2019 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants