Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

feat(dom): Convert JS to TypeScript #4269

Merged
merged 4 commits into from
Jan 19, 2019
Merged

feat(dom): Convert JS to TypeScript #4269

merged 4 commits into from
Jan 19, 2019

Conversation

acdvorak
Copy link
Contributor

Refs #4225

@acdvorak acdvorak requested a review from moog16 January 18, 2019 22:56
moog16
moog16 suggested changes Jan 18, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Jan 18, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feat/typescript@1600b54). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             feat/typescript    #4269   +/-   ##
==================================================
  Coverage                   ?   98.56%           
==================================================
  Files                      ?       92           
  Lines                      ?     5633           
  Branches                   ?      759           
==================================================
  Hits                       ?     5552           
  Misses                     ?       81           
  Partials                   ?        0
Impacted Files Coverage Δ
packages/mdc-dom/ponyfill.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1600b54...1051d5d. Read the comment docs.

moog16
moog16 approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kfranqueiro kfranqueiro mentioned this pull request Jan 18, 2019
Closed
45 tasks
@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit a50f183 vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit 5210181 vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit 1051d5d vs. feat/typescript! 💯🎉

@acdvorak acdvorak merged commit 66c8d81 into feat/typescript Jan 19, 2019
@acdvorak acdvorak deleted the feat/typescript--dom branch January 19, 2019 00:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moog16 moog16 moog16 approved these changes

Assignees

@moog16 moog16

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acdvorak @codecov-io @mdc-web-bot @moog16 @googlebot