Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #578

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

solution #578

wants to merge 17 commits into from

Conversation

Shevchuchka
Copy link

@Shevchuchka Shevchuchka commented Feb 9, 2025

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no demo link, you need to add demo link to the PR description
image

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, check plz your demo link
image
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Add the topical title and favicon on the page
image
  1. Add cursor pointer for all clickable elements on the page
image
  1. Open this additional link in the new tab
image
  1. Add the your github profile for all these links
image
  1. I can't change image when swiping
image
  1. Add transition when this menu appears on the page
image

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!

  1. you dont need scroll bar here
    image
  2. it would be better to limit max width of pages block
    image
  3. it should be aligned
    image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. its better to implement this logic
image
  1. total items count should be 8
image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. select capacity still doesn't work
image
  1. good job in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants