-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress: Web tables #262
base: main
Are you sure you want to change the base?
Cypress: Web tables #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on setting up the configuration and user generation! 🎉 While there are some minor redundancies and a potential issue with the table assertion, these don't critically impact the functionality. Keep up the good work and consider refining these areas in future updates!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
} else { | ||
cy.get('.rt-tbody').should('not.exist'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertion cy.get('.rt-tbody').should('not.exist');
might not be correct if the table body element is still present but empty. Consider checking for the absence of rows instead.
cy.get('#userEmail').should('exist').and('be.visible'); | ||
cy.get('#userEmail').should('exist').and('be.visible') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check for '#userEmail' existence and visibility is duplicated. You can remove one of these checks to avoid redundancy.
cy.get('#age').should('exist').and('be.visible'); | ||
cy.get('#age').should('exist').and('be.visible') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check for '#age' existence and visibility is duplicated. You can remove one of these checks to avoid redundancy.
cy.get('#salary').should('exist').and('be.visible'); | ||
cy.get('#salary').should('exist').and('be.visible') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check for '#salary' existence and visibility is duplicated. You can remove one of these checks to avoid redundancy.
cy.get('#department').should('exist').and('be.visible'); | ||
cy.get('#department').should('exist').and('be.visible') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check for '#department' existence and visibility is duplicated. You can remove one of these checks to avoid redundancy.
No description provided.