added two tests #332
Open
added two tests #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zakhar27
reviewed
Mar 18, 2024
cypress/e2e/bookStore.cy.js
Outdated
| it('', () => { | ||
|
|
||
| it('should allow to search for the book', () => { | ||
| cy.login(); |
There was a problem hiding this comment.
You could also add user object field's to request body. And then input user object as a parameter when you call this command to fully use user object) Well done anyway
djtyrf312
suggested changes
Mar 18, 2024
cypress/e2e/bookStore.cy.js
Outdated
| it('', () => { | ||
|
|
||
| it('should allow to search for the book', () => { | ||
| cy.login(); |
cypress/e2e/bookStore.cy.js
Outdated
| it('', () => { | ||
|
|
||
| it('should allow to search for the book', () => { | ||
| cy.login(); |
There was a problem hiding this comment.
Suggested change
| cy.login(); | |
| cy.login(user.username, user.password); |
cypress/e2e/bookStore.cy.js
Outdated
| cy.login(); | ||
| cy.visit('/books'); | ||
| cy.get('#searchBox') | ||
| .type('Speaking JavaScript'); |
There was a problem hiding this comment.
create a const for 'Speaking JavaScript' string and reuse it
cypress/support/commands.js
Outdated
| @@ -23,3 +23,20 @@ | |||
| // | |||
| // -- This will overwrite an existing command -- | |||
| // Cypress.Commands.overwrite('visit', (originalFn, url, options) => { ... }) | |||
| import './commands'; | |||
|
|
|||
| Cypress.Commands.add('login', () => { | |||
There was a problem hiding this comment.
Suggested change
| Cypress.Commands.add('login', () => { | |
| Cypress.Commands.add('login', (username, password) => { |
cypress/support/commands.js
Outdated
Comment on lines
33
to
34
| userName: 'Flood', | ||
| password: 'qwert!Q12345' |
There was a problem hiding this comment.
Suggested change
| userName: 'Flood', | |
| password: 'qwert!Q12345' | |
| userName: username, | |
| password: password, |
Huskov-Anton
suggested changes
Mar 18, 2024
cypress/support/commands.js
Outdated
| @@ -23,3 +23,20 @@ | |||
| // | |||
| // -- This will overwrite an existing command -- | |||
| // Cypress.Commands.overwrite('visit', (originalFn, url, options) => { ... }) | |||
| import './commands'; | |||
|
|
|||
| Cypress.Commands.add('login', () => { | |||
cypress/support/commands.js
Outdated
Comment on lines
33
to
34
| userName: 'Flood', | ||
| password: 'qwert!Q12345' |
djtyrf312
suggested changes
Mar 18, 2024
cypress/e2e/bookStore.cy.js
Outdated
Comment on lines
7
to
8
| textForSearching: 'Speaking JavaScript', | ||
| title: 'Speaking JavaScript', |
There was a problem hiding this comment.
Suggested change
| textForSearching: 'Speaking JavaScript', | |
| title: 'Speaking JavaScript', | |
| textForSearching: 'Speaking JavaScript', | |
| title: 'Speaking JavaScript', |
why do you need two the same variables but with the different name? left 1 variable and reuse it
Huskov-Anton
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.